NotificationsYou must be signed in to change notification settings
Fork753
Star5.5k

Refactor firstchar function for conciseness and modern syntax#555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Ayoub-Mabrouk wants to merge1 commit intoexpressjs:master

base:master

Choose a base branch

fromAyoub-Mabrouk:chore/firstChar

Open

Refactor firstchar function for conciseness and modern syntax#555

Ayoub-Mabrouk wants to merge1 commit intoexpressjs:masterfromAyoub-Mabrouk:chore/firstChar

Conversation

Copy link

Contributor

Ayoub-Mabrouk commentedOct 31, 2024

Replaced var with const for improved variable management
Used optional chaining for a more concise return statement
Enhanced readability while preserving functionality

Refactor firstchar function for conciseness and modern syntax

aec6065

- Replaced var with const for improved variable management- Used optional chaining for a more concise return statement- Enhanced readability while preserving functionality

UlisesGascon approved these changes

Oct 31, 2024

View reviewed changes

UlisesGascon requested a review frombjohansebas

October 31, 2024 14:57

bjohansebas approved these changes

Nov 2, 2024

View reviewed changes

wesleytodd requested changes

Nov 14, 2024

View reviewed changes

Copy link

Member

wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I see approvals on this. We have never accepted style changes before, and I dont believe we should now. But this maybe a discussion we need to have at the TC level?