NotificationsYou must be signed in to change notification settings
Fork8
Star8

move contributing and collaboration guide to .github#10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

wesleytodd merged 11 commits intoexpressjs:masterfrombjohansebas:add-contributing

May 21, 2025

Merged

move contributing and collaboration guide to .github#10

wesleytodd merged 11 commits intoexpressjs:masterfrombjohansebas:add-contributing

May 21, 2025

Conversation

Copy link

Member

bjohansebas commentedNov 15, 2024•
edited
Loading

This is part of adding the documentation that can be inherited from this repository.

Port of#18

bjohansebas commentedNov 15, 2024

cc: @expressjs/express-tc

This comment was marked as outdated.

wesleytodd requested changes

Jan 14, 2025

View reviewed changes

Copy link

Member

wesleytodd left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I dont like that added complexity of the admin repo. I was thinking we should make the.github repo the source for all we can. Honestly the name of the repo doesn't really matter as long as the docs are in the right place and the links are all correct.

My main concern with this current form is that we dont have a good concept in here of the difference between contributing toexpress vs all the other packages. I think we should keep this in a branch and open PRs against it here until we are satisfied. This whole consolidation effort was one of the main things I wanted to do soon, so let me just leave this comment here and circle back in a week or so.

Copy link

Member

ctcpip commentedJan 14, 2025

Agree with Wes. Frankly, we have a backlog of updating the contributing guide, as well as the security policy -- something we delayed doing until after the audit was complete and we were in 2025.

docs: add contributing.md

d229261

bjohansebas force-pushed theadd-contributing branch from406cd82 to59f2418Compare

March 30, 2025 02:05

bjohansebas added3 commits

March 29, 2025 21:06

docs: rename contributing to governance

59f2418

port:expressjs#18

b81aee7

docs: add contributing guide for Express collaboration

cd6ef39

bjohansebas changed the title~~docs: add contributing.md~~move contributing and collaboration guide to .github

Mar 30, 2025

bjohansebas requested a review fromwesleytodd

March 30, 2025 02:18

Copy link

MemberAuthor

bjohansebas commentedMar 30, 2025•
edited
Loading

wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Anything to pull this out of theexpress repo is good, but I do think the governence docs are not supported by GH to show in every repo, and also they apply for us to all three orgs, so we may be better off with that one indiscussions than here.