explosion/preshedPublic

NotificationsYou must be signed in to change notification settings
Fork24
Star87

Support the free-threaded build#54

Merged

ngoldbaum merged 21 commits intoexplosion:v3.0.xfrom

ngoldbaum:ft-staging

Nov 18, 2025

Merged

Support the free-threaded build#54
ngoldbaum merged 21 commits intoexplosion:v3.0.xfrom
ngoldbaum:ft-staging

Conversation

Copy link

Contributor

ngoldbaum commentedNov 13, 2025

Adds support for the free-threaded build.

I madeBloomFilter andPreshedMap thread-safe under the free-threaded build using critical sections. I also added tests for multithreaded sharing ofBloomFilter andPreshedMap.

The other types are not used by spaCy so I don't think it's worth updating them. Ideally I'd document this somewhere, but this project has very minimal docs, so it's not clear where I'd put that.

There's also a few changes included that aren't strictly related to free-threaded support:

Added testing on GIL-enabled Python 3.14
Moved from deprecated macos-13 runner to macos-15-intel
deleted a repeated prototype inbloom.pxd
Used a C++ vector instead of anarray.array in theBloomFilter serialization. This is substantially faster and makes the multithreaded test I added substantially faster.

ngoldbaum added16 commits

November 11, 2025 14:06

add testing on 3.13t, 3.14, and 3.14t

0e9fae6

temporarily enable testing on forks

b3e180f

set PYTHON_GIL=0 for free-threaded test environments

38ca36d

relax python_requires upper limit

add923c

add TODO comment

0a2870b

depend on cymem free-threading fork and murmurhash master branch

b19d2ce

Implement bloom serialization with a C++ vector

e56aa08

apply critical sections in BloomFilter

158b6c7

add a multithreaded bloom filter test

e4b0e97

drop 3.13t, use macos-latest-intel

bc418fb

Bloom filter thread safety pass (#3)

3b577fb

* tweak comments* Simplify critical sections* avoid resource leak

create a new file for multithreaded tests

ff9c6af

thread safety pass for preshed.map

330116c

move depedendencies to upstream cymem and murmurhash to use new releases

4c7158e

mark extensions as compatible with the free-threaded build

6e28c7c

update trove classifiers

1964bca

honnibal reviewed

Nov 14, 2025

View reviewed changes

preshed/bloom.pyxShow resolvedHide resolved

add comments

b0a3cde

crusaderky reviewed

Nov 17, 2025

View reviewed changes

setup.py OutdatedShow resolvedHide resolved

preshed/bloom.pyxShow resolvedHide resolved

preshed/bloom.pxdShow resolvedHide resolved

preshed/maps.pyxShow resolvedHide resolved

preshed/maps.pyx

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This module would greatly benefit from a RWLock.
Might be worth adding an issue for follow-up.

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd rather only do that if this shows up as a performance bottleneck.

ngoldbaumand others added3 commits

November 17, 2025 09:58

Apply suggestions from code review

fcbea62

Co-authored-by: Guido Imperiale <crusaderky@gmail.com>

add comments explaining thread safety guarantees

9a2e34b

Describe thread safety guarantees in the readme

bd3732f

Copy link

ContributorAuthor

ngoldbaum commentedNov 17, 2025

I went ahead and added a couple sentences to the readme along with the comments@crusaderky suggested.

spelling and mention PreshCounter

5cded50

crusaderky approved these changes

Nov 18, 2025

View reviewed changes

Copy link

ContributorAuthor

ngoldbaum commentedNov 18, 2025

OK, let's merge this. Rather than doing a release ASAP with cp314t wheels, we're going to first set up nightly wheels (scientific-python/upload-nightly-action#146) and then set up nightly testing for packages like spaCy further up the stack. Once the full stack is working, we'll do coordinated releases of all the packages including cp314t wheels.