Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Captain's Log: Fix random override cleanup#2734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
SleeplessByte wants to merge2 commits intomain
base:main
Choose a base branch
Loading
fromchore/fix-captains-log-tests

Conversation

SleeplessByte
Copy link
Member

@SleeplessByteSleeplessByte commentedJul 27, 2025
edited
Loading

See:https://forum.exercism.org/t/tests-instructions-not-displayed/18559/6

(Do not merge quite yet, testing now locally if this actually solves it, will remove this message when done)

We also need a test-runner update forbeforeEach per describe. Will fix that too.

Do not merge yet

When we merge this without updating the browser-test-runner, you won't be able to complete this in the browser anymore. Right now in the browser you can complete it by starting the tests 3x once it fails.

@github-actionsGitHub Actions
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR doesnot affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for),please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to thedocumentation. If you are unsure whether to add the message or not, please ping@exercism/maintainers-admin in a comment. Thank you!

SleeplessByte reacted with thumbs up emoji

@SleeplessByteSleeplessByte added the do not merge 🚧Don't merge until this label is removed labelJul 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
1 more reviewer

@IsaacGIsaacGIsaacG approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge 🚧Don't merge until this label is removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@SleeplessByte@IsaacG

[8]ページ先頭

©2009-2025 Movatter.jp