Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

🐛 FIX: Spurious newline in generated literal_block nodes#541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
cpitclaudel wants to merge3 commits intoexecutablebooks:master
base:master
Choose a base branch
Loading
fromcpitclaudel:cpitclaudel_407

Conversation

cpitclaudel
Copy link
Contributor

@cpitclaudelcpitclaudel commentedApr 1, 2022
edited
Loading

Closes#407. The details are in the original bug report, but the long story short is that Docutils already adds a newline to its<pre> blocks, so we don't need one more. I opted to fix allliteral_blocks, but the most important ones are the ones increate_highlighted_code_block.

@chrisjsewell
Copy link
Member

Cheers@cpitclaudel, I will have a look probably Monday now

cpitclaudel reacted with thumbs up emoji

@codecov
Copy link

codecovbot commentedApr 13, 2022
edited
Loading

Codecov Report

Merging#541 (45c32c8) intomaster (8f53a0b) willdecrease coverage by0.06%.
The diff coverage is83.33%.

@@            Coverage Diff             @@##           master     #541      +/-   ##==========================================- Coverage   89.78%   89.72%   -0.07%==========================================  Files          16       16                Lines        2104     2111       +7     ==========================================+ Hits         1889     1894       +5- Misses        215      217       +2
FlagCoverage Δ
pytests89.72% <83.33%> (-0.07%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Impacted FilesCoverage Δ
myst_parser/docutils_renderer.py91.86% <83.33%> (+0.07%)⬆️
myst_parser/mocking.py85.43% <0.00%> (-0.79%)⬇️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update8f53a0b...45c32c8. Read thecomment docs.

@chrisjsewell
Copy link
Member

Thanks@cpitclaudel this requires fixes for a number of the regression tests (if you didn't know you can runpytest --force-regen

My question would be though; should the behaviour be the same for docutils and sphinx? i.e.does the sphinx builder also require this new line removal?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spurious newline in generatedliteral_block nodes

2 participants

@cpitclaudel@chrisjsewell

[8]ページ先頭

©2009-2025 Movatter.jp