- Notifications
You must be signed in to change notification settings - Fork215
🐛 FIX: Spurious newline in generated literal_block nodes#541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Cheers@cpitclaudel, I will have a look probably Monday now |
codecovbot commentedApr 13, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #541 +/- ##==========================================- Coverage 89.78% 89.72% -0.07%========================================== Files 16 16 Lines 2104 2111 +7 ==========================================+ Hits 1889 1894 +5- Misses 215 217 +2
Flags with carried forward coverage won't be shown.Click here to find out more.
Continue to review full report at Codecov.
|
Thanks@cpitclaudel this requires fixes for a number of the regression tests (if you didn't know you can run My question would be though; should the behaviour be the same for docutils and sphinx? i.e.does the sphinx builder also require this new line removal? |
Uh oh!
There was an error while loading.Please reload this page.
Closes#407. The details are in the original bug report, but the long story short is that Docutils already adds a newline to its
<pre>
blocks, so we don't need one more. I opted to fix allliteral_blocks
, but the most important ones are the ones increate_highlighted_code_block
.