- Notifications
You must be signed in to change notification settings - Fork1.9k
Feature/Add comments/notes to stream writer#911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
guyonroche merged 2 commits intoexceljs:masterfrombrunoargolo:FEATURE/ADD-COMMENTS-TO-STREAM-WRITEROct 2, 2019
Merged
Feature/Add comments/notes to stream writer#911
guyonroche merged 2 commits intoexceljs:masterfrombrunoargolo:FEATURE/ADD-COMMENTS-TO-STREAM-WRITEROct 2, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Hi@Siemienik /@alubbe /@guyonroche , Any feedback on this PR? I'd like to also implement add image for the stream writer but was waiting for this PR to merge first. If you have a different approach in mind let me know. |
@brunoargolo looks good. I'll transform the test code you wrote into an integration test - this way it will be checked during publishes. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when using stream.xlsx.WorkbookWriter adding a note to a cell will result in an exception.
The "issue" was documented in#868, but comments/notes were simply not introduced for the stream writter yet.
Please let me know if anything is needed on my end for this PR.