Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Feature/Sheet Protection#907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@karabaesh
Copy link
Contributor

Changes:

  • New feature: Ability to protect and unprotect worksheets

Siemienik reacted with hooray emoji
@karabaeshkarabaesh changed the titleNew feature: Sheet protectionFeature/Sheet-ProtectionJul 31, 2019
@karabaeshkarabaesh changed the titleFeature/Sheet-ProtectionFeature/Sheet ProtectionJul 31, 2019
Signed-off-by: Karabaesh <karabaesh@users.noreply.github.com>
Copy link
Member

@SiemienikSiemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cool, It's a great request:)

Everything from code side looks fine for me, so I approve it.

Could anyone confirm that this feature works fine?

Copy link
Collaborator

@guyonrocheguyonroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@karabaesh Thank you for working on this PR - it will be a great addition to exceljs
I've made a few comments - could you take a look?

Copy link
ContributorAuthor

@karabaeshkarabaesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Applied some changed according to guyonroche's requests.

Copy link
ContributorAuthor

@karabaeshkarabaesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes have been implemented

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@guyonrocheguyonrocheguyonroche requested changes

@SiemienikSiemienikSiemienik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karabaesh@guyonroche@Siemienik
[8]ページ先頭
©2009-2025 Movatter.jp