NotificationsYou must be signed in to change notification settings
Fork1.9k
Star15k

Exclude Infinity on createInputStream#906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

guyonroche merged 3 commits intoexceljs:masterfromsophiedophie:bugfix/exclude-infinity-from-number

Oct 2, 2019

Merged

Exclude Infinity on createInputStream#906

guyonroche merged 3 commits intoexceljs:masterfromsophiedophie:bugfix/exclude-infinity-from-number

Oct 2, 2019

Conversation

Copy link

Contributor

sophiedophie commentedJul 31, 2019

Character such as6E10000 becomes Infinity withNumber()
but it's notNaN, so just returns it.
It causes error for excel file so can't open generated file.

We need to check if it's Infinity or not.

Exclude Infinity on createInputStream

be4381a

Character such as `6E10000` becomes Infinity with `Number()`but it's not `NaN`, so just returns it.It causes error for excel file so can't open generated file.We need to check if it's Infinity or not.