Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix anchor.js#892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
guyonroche merged 1 commit intoexceljs:masterfromwwojtkowski:patch-1
Oct 18, 2019
Merged

Fix anchor.js#892

guyonroche merged 1 commit intoexceljs:masterfromwwojtkowski:patch-1
Oct 18, 2019

Conversation

wwojtkowski
Copy link
Contributor

It doesn't work when you have the address with nativeCol = 0

It doesn't work when you have the address with nativeCol = 0
@Siemienik
Copy link
Member

Col and row are always >= 1

But rigth, that's good pull request

@Siemienik
Copy link
Member

@wwojtkowski could i please you for write a test that's failed this code before changes?

@wwojtkowski
Copy link
ContributorAuthor

Col and row are always >= 1

But rigth, that's good pull request

I cannot agree with you. Rows are always >= 1 but not col.
I have Excel's file where I have images in the first column in every row.
In the Anchor class nativeCol has 0 value but nativeRow has proper value (>=1).
Before my fix, all images from worksheet have nativeRow = 0 and nativeCol = 0 - which is a very serious bug.
Zrzut ekranu 2019-07-13 o 18 27 15

@Siemienik
Copy link
Member

@wwojtkowski ok, thanks for the explanation :)

I want to merge it, but it's required to cover changes by tests

@vidyakin
Copy link

@Siemienik , I have error with the word 'anchor' when call openFile, may it be the same problem? :)

TypeError: Cannot read property 'anchors' of undefined    at DrawingXform.reconcile (C:\web\my_prj\node_modules\exceljs\lib\xlsx\xform\drawing\drawing-xform.js:94:11)    at Object.keys.forEach.name (C:\web\my_prj\node_modules\exceljs\lib\xlsx\xlsx.js:103:22)    at Array.forEach (<anonymous>)    at XLSX.reconcile (C:\web\my_prj\node_modules\exceljs\lib\xlsx\xlsx.js:95:33)    at PromiseLib.Promise.all.then (C:\web\my_prj\node_modules\exceljs\lib\xlsx\xlsx.js:389:16)

But it appears in the ONLY Excel file that is important for my task!
And there are some interesting things I found:

  • If I copy all worksheet and paste to new workbook, it works.
  • If I run in Excel "check compatibility" function and do correct operation - it works!

@guyonrocheguyonroche merged commitf7c5e1f intoexceljs:masterOct 18, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@wwojtkowski@Siemienik@vidyakin@guyonroche

[8]ページ先頭

©2009-2025 Movatter.jp