Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Uprev fast-csv to latest version which does not use unsafe eval#873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
alubbe merged 5 commits intoexceljs:masterfrommiketownsend:fix-unsafe-eval
Oct 7, 2019

Conversation

miketownsend
Copy link
Contributor

fast-csv@2.4.1 uses a dependencyhttps://www.npmjs.com/package/extended which uses an unsafe eval.

If we update fast-csv@3.0.1 to the latest version, which has lodash as it's only dependency it should solve this issue:#713

joshuanapoli and dboune reacted with thumbs up emoji
@miketownsend
Copy link
ContributorAuthor

@guyonroche - any ideas about this?

>> Uglifying source ./dist/exceljs.js failed.Warning: Uglification failed.Unexpected token: keyword «const».Line 43131 in ./dist/exceljs.js Use --force to continue.

The fast-csv module and dependencies are still using "const" which is causing the uglification to fail.

I'm not sure why that one module would not be handled by babel in the same way as the other files. Am I missing something obvious here?

dboune reacted with thumbs up emoji

@paoesco
Copy link

Answer is here :https://davidburgos.blog/how-to-fix-grunt-contrib-uglify-for-es6/

grunt uglify master does not support (yet?) es6 so we need to use the branch harmony.

miketownsend reacted with thumbs up emoji

@paoesco
Copy link

  1 failing  1) Workbook       Serialise         csv file:     TypeError: csv.createWriteStream is not a function      at /home/travis/build/exceljs/exceljs/lib/csv/csv.js:96:29      at new Promise (<anonymous>)      at module.exports.write (lib/csv/csv.js:88:12)      at module.exports.writeFile (lib/csv/csv.js:156:17)      at Context.<anonymous> (spec/integration/workbook/workbook.spec.js:451:10)      at processImmediate (internal/timers.js:439:21)

I guess it's because fast csv has been updated and so certainly we need to change some calls

miketownsend reacted with thumbs up emoji

@alubbe
Copy link
Member

Looks good

@alubbealubbe merged commitdbcece7 intoexceljs:masterOct 7, 2019
@miketownsendmiketownsend deleted the fix-unsafe-eval branchOctober 7, 2019 09:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alubbealubbealubbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@miketownsend@paoesco@alubbe@guyonroche
[8]ページ先頭
©2009-2025 Movatter.jp