Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix defaultRowHeight not working#855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
guyonroche merged 2 commits intoexceljs:masterfromautukill:master
Jun 13, 2019
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletionslib/xlsx/xform/sheet/sheet-format-properties-xform.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,7 @@ class SheetFormatPropertiesXform extends BaseXform {
outlineLevelRow: model.outlineLevelRow,
outlineLevelCol: model.outlineLevelCol,
'x14ac:dyDescent': model.dyDescent,
customHeight: model.defaultRowHeight === 0 ? '0' : '1',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you fix the unit tests that have failed due to this change

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes

};
if (_.some(attributes, value => value !== undefined)) {
xmlStream.leafNode('sheetFormatPr', attributes);
Expand Down
2 changes: 1 addition & 1 deletionspec/unit/xlsx/xform/sheet/data/sheet.1.2.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
<sheetViews>
<sheetView workbookViewId="0"/>
</sheetViews>
<sheetFormatPr defaultRowHeight="15" x14ac:dyDescent="0.25"/>
<sheetFormatPr defaultRowHeight="15"customHeight="1"x14ac:dyDescent="0.25"/>
<sheetPr>
<tabColor rgb="FF00FF00"/>
<pageSetUpPr fitToPage="1"/>
Expand Down
2 changes: 1 addition & 1 deletionspec/unit/xlsx/xform/sheet/data/sheet.2.2.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
<sheetViews>
<sheetView workbookViewId="0"/>
</sheetViews>
<sheetFormatPr defaultRowHeight="14.4" x14ac:dyDescent="0.55" outlineLevelRow="2"/>
<sheetFormatPr defaultRowHeight="14.4"customHeight="1"x14ac:dyDescent="0.55" outlineLevelRow="2"/>
<sheetData>
<row r="1" spans="1:3" x14ac:dyDescent="0.25">
<c r="A1" t="s">
Expand Down
2 changes: 1 addition & 1 deletionspec/unit/xlsx/xform/sheet/data/sheet.3.2.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<worksheet xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main" xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships" xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" mc:Ignorable="x14ac" xmlns:x14ac="http://schemas.microsoft.com/office/spreadsheetml/2009/9/ac">
<dimension ref="A1:A1"/>
<sheetFormatPr defaultRowHeight="14.4" x14ac:dyDescent="0.55" outlineLevelRow="2"/>
<sheetFormatPr defaultRowHeight="14.4"customHeight="1"x14ac:dyDescent="0.55" outlineLevelRow="2"/>
<sheetData/>
</worksheet>
2 changes: 1 addition & 1 deletionspec/unit/xlsx/xform/sheet/data/sheet.5.2.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<worksheet xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main" xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships" xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" mc:Ignorable="x14ac" xmlns:x14ac="http://schemas.microsoft.com/office/spreadsheetml/2009/9/ac">
<dimension ref="A1:B1"/>
<sheetFormatPr defaultRowHeight="14.4" x14ac:dyDescent="0.55" outlineLevelRow="2"/>
<sheetFormatPr defaultRowHeight="14.4"customHeight="1"x14ac:dyDescent="0.55" outlineLevelRow="2"/>
<sheetData>
<row r="1" spans="1:3" x14ac:dyDescent="0.25">
<c r="A1">
Expand Down
2 changes: 1 addition & 1 deletionspec/unit/xlsx/xform/sheet/data/sheet.6.2.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<worksheet xmlns="http://schemas.openxmlformats.org/spreadsheetml/2006/main" xmlns:r="http://schemas.openxmlformats.org/officeDocument/2006/relationships" xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" mc:Ignorable="x14ac" xmlns:x14ac="http://schemas.microsoft.com/office/spreadsheetml/2009/9/ac">
<dimension ref="A1:B1"/>
<sheetFormatPr defaultRowHeight="14.4" x14ac:dyDescent="0.55" outlineLevelRow="2"/>
<sheetFormatPr defaultRowHeight="14.4"customHeight="1"x14ac:dyDescent="0.55" outlineLevelRow="2"/>
<sheetData>
<row r="1" spans="1:2" x14ac:dyDescent="0.25">
<c r="A1">
Expand Down
2 changes: 1 addition & 1 deletionspec/unit/xlsx/xform/sheet/data/sheet.7.2.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@
<sheetViews>
<sheetView workbookViewId="0"/>
</sheetViews>
<sheetFormatPr defaultRowHeight="14.4" x14ac:dyDescent="0.55" outlineLevelRow="2"/>
<sheetFormatPr defaultRowHeight="14.4"customHeight="1"x14ac:dyDescent="0.55" outlineLevelRow="2"/>
<sheetData>
<row r="1" spans="1:3" x14ac:dyDescent="0.25">
<c r="A1" t="s">
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@ const expectations = [
outlineLevelCol: 2,
},
xml:
'<sheetFormatPr defaultRowHeight="14.4" outlineLevelRow="5" outlineLevelCol="2" x14ac:dyDescent="0.55"/>',
'<sheetFormatPr defaultRowHeight="14.4"customHeight="1"outlineLevelRow="5" outlineLevelCol="2" x14ac:dyDescent="0.55"/>',
parsedModel: {
defaultRowHeight: 14.4,
dyDescent: 0.55,
Expand All@@ -30,8 +30,8 @@ const expectations = [
create() {
return new SheetFormatPropertiesXform();
},
preparedModel: {defaultRowHeight: 14.4, dyDescent: 0.55},
xml: '<sheetFormatPr defaultRowHeight="14.4" x14ac:dyDescent="0.55"/>',
preparedModel: {defaultRowHeight: 14.4, dyDescent: 0.55},
xml: '<sheetFormatPr defaultRowHeight="14.4"customHeight="1"x14ac:dyDescent="0.55"/>',
parsedModel: {
defaultRowHeight: 14.4,
dyDescent: 0.55,
Expand Down
[8]ページ先頭
©2009-2025 Movatter.jp