- Notifications
You must be signed in to change notification settings - Fork1.9k
Always keep first font#854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@guyonroche Hi! |
package.json Outdated
| { | ||
| "name":"exceljs", | ||
| "version":"1.12.1", | ||
| "version":"1.12.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please don't edit this - it is managed during the release/publish process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ok
| horizontal:'left', | ||
| vertical:'middle', | ||
| }, | ||
| expect(ws.getRow(3).style.alignment).to.deep.equal({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you add a test that covers your change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it took o lot of time to find the issue, not sure i'll be able cover with tests coming days
Uh oh!
There was an error while loading.Please reload this page.
Font skipped each time, when
styleId===0related issues
#849
#833
#816