Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add comment support #529#823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
guyonroche merged 1 commit intoexceljs:masterfromilimei:comment
May 22, 2019
Merged

Conversation

ilimei
Copy link

Fixes issue#529

@guyonroche
Copy link
Collaborator

@ilimei thank you for your contribution - this looks good. Could you do one thing? Please use 2 spaces for indents - I know it's pedantic but it helps with consistency

@ilimei
Copy link
Author

@guyonroche sorry for that, i will do it later ^_^

@guyonrocheguyonroche merged commitfd6189c intoexceljs:masterMay 22, 2019
@guyonroche
Copy link
Collaborator

@ilimei after some futher testing, I've started working on some changes...

  1. changing the Cell property name from "comment" to "note" -> this reflects the change in Excel from comments to "Threaded Comments". The old legacy comments are called Notes
  2. It turns out that each note (or comment) requires the addition of a vml drawing for each cell note. Sometimes the design decisions of MS Excel developers astounds me!

@guyonroche
Copy link
Collaborator

Changes are in and published to 1.12.0
@ilimei thanks for your contribution

@alexcrack
Copy link

alexcrack commentedJul 23, 2019
edited
Loading

Hello.

  1. Comment's names in the interface file *.d.ts (and in @types/exceljs module) called 'comment' (not 'note') as before.
  2. Comments are not popupable. They are displayed constantly. But Excel (and Libre Calc) CAN do them popup on cell hover. How can I code behavior this way?

Can't you check it please?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@ilimei@guyonroche@alexcrack@mepd

[8]ページ先頭

©2009-2025 Movatter.jp