- Notifications
You must be signed in to change notification settings - Fork1.9k
fix issue with print area defined name corrupting file#822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
fix issue with print area defined name corrupting file#822
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…per prettier. update test coverage and apply same format when reconciling printTitles and printArea
In my project I experienced the corruption as a result of adding a printArea to a sheet with a name with a space in it ("sheet title", for example). That is the main issue I observed that motivated this PR. |
@Siemienik This PR precedes my PR for headerFooter, in order to separate concerns. |
Uh oh!
There was an error while loading.Please reload this page.
@donaldsonjulia - Thank you for contributing :-) Are you sure this fixes issue#705 ? I thought that issue was about worksheet names |
… update test to avoid lint error
3747e31 to3a9d6cbCompare@guyonroche You are correct about issue#705, sorry for the confusion! I removed it from the description. Late night PR summaries with too many tabs in my browser :) |
Uh oh!
There was an error while loading.Please reload this page.
PR includes:
Fix file corruption caused by
printAreadefined name. As described in issue below:Defined Names Break/Corrupt Excel File into Repair Mode #664
Lint updates required by prettier in committed files.
Handle formatting of reconciled printArea, printTitlesRow, and printTitlesColumn the same, so all are serialized as
A:A(not$A:$A), in following with the documented format for specifying a sheet's printTitlesRow, etc. (ws.pageSetup.printTitlesRow = 'A:B';)Update tests accordingly (per format changes above) and add test
testPrintAreaOut.js