- Notifications
You must be signed in to change notification settings - Fork1.9k
fix issue with print area defined name corrupting file#822
Merged
guyonroche merged 3 commits intoexceljs:masterfromMay 31, 2019
Merged
Conversation
…per prettier. update test coverage and apply same format when reconciling printTitles and printArea
ContributorAuthor
donaldsonjulia commentedMay 18, 2019
In my project I experienced the corruption as a result of adding a printArea to a sheet with a name with a space in it ("sheet title", for example). That is the main issue I observed that motivated this PR. |
ContributorAuthor
donaldsonjulia commentedMay 19, 2019
@Siemienik This PR precedes my PR for headerFooter, in order to separate concerns. |
guyonroche requested changesMay 21, 2019
Uh oh!
There was an error while loading.Please reload this page.
Collaborator
guyonroche commentedMay 21, 2019
@donaldsonjulia - Thank you for contributing :-) Are you sure this fixes issue#705 ? I thought that issue was about worksheet names |
… update test to avoid lint error
3747e31 to3a9d6cbCompareContributorAuthor
donaldsonjulia commentedMay 21, 2019
@guyonroche You are correct about issue#705, sorry for the confusion! I removed it from the description. Late night PR summaries with too many tabs in my browser :) |
guyonroche approved these changesMay 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR includes:
Fix file corruption caused by
printAreadefined name. As described in issue below:Defined Names Break/Corrupt Excel File into Repair Mode #664
Lint updates required by prettier in committed files.
Handle formatting of reconciled printArea, printTitlesRow, and printTitlesColumn the same, so all are serialized as
A:A(not$A:$A), in following with the documented format for specifying a sheet's printTitlesRow, etc. (ws.pageSetup.printTitlesRow = 'A:B';)Update tests accordingly (per format changes above) and add test
testPrintAreaOut.js