Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs(README): improve docs#817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
zypA13510 wants to merge1 commit intoexceljs:masterfromzypA13510:patch-1
Closed

docs(README): improve docs#817

zypA13510 wants to merge1 commit intoexceljs:masterfromzypA13510:patch-1

Conversation

zypA13510
Copy link
Contributor

@zypA13510zypA13510 commentedMay 16, 2019•
edited
Loading

  • Added documentation ofwriteBuffer() method.
  • Moved CSV read code block to the corresponding section.
  • Remove the duplicated CSV read code.

- Added documentation of `writeBuffer()` method.- Moved CSV read code block to the corresponding section.
@zypA13510
Copy link
ContributorAuthor

@guyonroche The duplicated read CSV code actually existssince 2015, could you confirm which version (because it's different) of "read from a file with European Date-Times" and "read from a file with custom value formatting" do you want to keep?

Copy link
Collaborator

@guyonrocheguyonroche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@zypA13510 yeah - probably a result of copy-paste documentation...

Thanks for adding the writeBuffer() examples.

I think though - the example following the comment "read from a file with custom value formatting" is supposed to be "write to a file..." as mapping values is also a feature of csv.write

@guyonroche
Copy link
Collaborator

Merged (as part ofb567395)

@zypA13510zypA13510 deleted the patch-1 branchJune 6, 2019 17:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@guyonrocheguyonrocheguyonroche requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@zypA13510@guyonroche
[8]ページ先頭
©2009-2025 Movatter.jp