- Notifications
You must be signed in to change notification settings - Fork1.9k
Avoid unhandled rejection on XML parse error#813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Avoid unhandled rejection on XML parse error#813
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…errorPrevents a parse error from causing an unhandled rejection
There seems to something wrong with your prettier configuration, did you run |
The |
@alubbe regarding the prettier - I changed the config to be lint only - without the fixing as I ended up with a situation where the fixer was outputting code that the linter rejected. In a way - I tend to prefer fixing the lint issues manually it gives the chance to fix the code in a better way than the lint fixer can |
Ran into some maliciously crafted .xlsx files that contained invalid XML, which triggered an unhandled rejection because the stream no longer had an error handler at that point. Seems like I introduced this bug myself back in#541, so it's only fair that I fix it.
The test case is a little out there, but I couldn't find another way to test for an unhandled rejection. The
workbook.xlsx.readFilepromise already got rejected as it was supposed to.