Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replace the temp lib to tmp#775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
defshift merged 1 commit intomasterfromfeature/replace-lib-for-temp-files
Apr 4, 2019

Conversation

defshift
Copy link
Contributor

Right we are using thetemp package for creating temp files to cache shared strings in the workbook reader. The problem is that thetemp uses a global cache to keep track of its files, which is not safe for concurrent operation. In particular, the cleanup of one task will delete all files tracked globally, incl. those still needed by another task. This results in a node error that a file was not found.

In this PR we replace thetemp totmp which is safe for concurrent operations.

@defshiftdefshift added the bug labelApr 3, 2019
Copy link
Member

@alubbealubbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We used this version in production since last December, no complaints

@defshiftdefshift merged commit43ba7ec intomasterApr 4, 2019
@defshiftdefshift deleted the feature/replace-lib-for-temp-files branchApril 4, 2019 10:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alubbealubbealubbe approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@defshift@alubbe

[8]ページ先頭

©2009-2025 Movatter.jp