Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add Worksheet.state typescript definition fix #714#736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Siemienik merged 4 commits intoexceljs:masterfromilyes-kechidi:add-ws-state-typedef
Feb 19, 2019

Conversation

@ilyes-kechidi
Copy link
Contributor

No description provided.

@alubbe
Copy link
Member

I checked that the default value of the work sheet state isshow, but from my understanding the same holds true for the options object when adding worksheets since it's just passed down to the constructor (in this PR, it's default value isvisible). In that case, we should define this enum once and the re-use it in both type definitions. what do you think@Siemienik@guyonroche ?

@Siemienik
Copy link
Member

@alubbe fully agree,

as far as i know, 'show' is invalid value, it should be 'visible'
#621

@SiemienikSiemienik self-requested a reviewFebruary 19, 2019 00:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@alubbealubbealubbe left review comments

@SiemienikSiemienikSiemienik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ilyes-kechidi@alubbe@Siemienik

[8]ページ先頭

©2009-2025 Movatter.jp