- Notifications
You must be signed in to change notification settings - Fork1.9k
drawing element must be below rowBreaks according to spec or corrupt worksheet#590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@guyonroche I appreciate you're busy but do you have an ETA for the next release? I'm currently blocked by this issue. Thanks |
Appologies for the delay - will test and publish today |
shuntagami added a commit to shuntagami/exceljs that referenced this pull requestDec 11, 2023
This was referencedDec 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an issue with adding both images and a pagebreak to a worksheet. Adding them independently was fine but adding them both together result in a corrupt document.
The issue was related to the ordering of the elements. drawing must be below rowBreaks as seen here:
https://stackoverflow.com/a/12221477/4564456
You can also see the ordering of all the other elements there in case this comes up with new features. Moving drawing and picture below rowBreaks fixes the issue.
I'm currently blocked until this is merged so please let me know if there's anything else I can do to help! :)
Thanks