Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix some xlsx stream read xlsx not in guaranteed order problem#578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
guyonroche merged 3 commits intoexceljs:masterfromKMethod:master
Nov 7, 2018
Merged

Conversation

@KMethod
Copy link

when stream read some xlsx files (like numbers convert to xlsx), get values like :
row.values [ ,
{ sharedString: 47 },
{ sharedString: 35 },
{ sharedString: 47 },
{ sharedString: 37 },
{ sharedString: 37 },
{ sharedString: 37 },
{ sharedString: 37 },
{ sharedString: 37 },
{ sharedString: 37 },
]

try to fix this problem

@KMethodKMethod changed the titleFix some xlsx stream read get sharedstring index problemFix some xlsx stream read xlsx not in guaranteed order problemMay 30, 2018
@guyonroche
Copy link
Collaborator

@KMethod my concern with this PR is the use of Temp, which won't work in a browser. The StreamBuf class (in utils) should provide an in-memory alternative

@KMethod
Copy link
Author

KMethod commentedJun 28, 2018
edited
Loading

@guyonroche Streaming XLSX are only exposed in NodeJS, so does it matter?

@guyonroche
Copy link
Collaborator

@KMethod Sorry this is dragging out - I don't have a huge amount of time these days.
It might matter - this change puts a dependency on the environment (i.e. temp folders).

I'm still not sure what problem this fix is solving. Can you give more details?

@guyonrocheguyonroche merged commit890c97d intoexceljs:masterNov 7, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KMethod@guyonroche

[8]ページ先頭

©2009-2025 Movatter.jp