- Notifications
You must be signed in to change notification settings - Fork1.9k
Don't break when docProps/core.xml contains <cp:contentType />#536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lib/xlsx/xform/core/core-xform.js Outdated
| 'cp:revision':newDateXform({tag:'cp:revision'}), | ||
| 'cp:version':newStringXform({tag:'cp:version'}), | ||
| 'cp:contentStatus':newStringXform({tag:'cp:contentStatus'}), | ||
| 'cp:contentType':newDateXform({tag:'cp:contentType'}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would think this should be aStringXform?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, you're right, nice catch. I had that originally, but started playing around because that enfant terrible spreadsheet still didn't parse :)
Fixed.
1eaede2 to3b46510Comparepapandreou commentedApr 10, 2018
I just learned that the Excel file in question is an export fromXero, which is a piece of accounting software. |
<cp:coreProperties ...><cp:contentType /></cp:coreProperties>
3b46510 to75e5f21Comparepapandreou commentedApr 10, 2018
I guess the |
salterok commentedApr 10, 2018
I also see documents with There is example of a such file |
papandreou commentedApr 10, 2018
@salterok, thanks for weighing in! I've added a regression test based on the file that you linked to. |
Uh oh!
There was an error while loading.Please reload this page.
I've encountered a spreadsheet that contains:
which causes exceljs to break with:
Unfortunately I'm not able to share the spreadsheet that this happened with, and I don't know how it was created. If it's important I can try to create a synthetic test case with this construct in it.