- Notifications
You must be signed in to change notification settings - Fork1.9k
Add correct parsing for inline strings#495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Inline strings that previously met the XML spec, caused the parsing of the files to fail.
robscotts4rb commentedFeb 7, 2018
@guyonroche I couldn't find the correct place to add tests around parsing of a file. If you can point me in the correct direction I am happy to add them |
guyonroche commentedMar 7, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@robscotts4rb sorry it's taken me so long to get to this. Would this mean we should be writing inline strings as Or do you think that might cause more problems than it solves? |
linguamatics-pdenes commentedMar 12, 2018
@guyonroche I tried to something similar in#501 and added a very basic unit test in there -- hope it makes sense! |
guyonroche commentedMar 15, 2018
@robscotts4rb thanks for the contribution - I'm going to merge#501 and close this one as they are both working to the same end |
Inline strings that previously met the XML spec, caused the parsing of the files to fail.