Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add correct parsing for inline strings#495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
robscotts4rb wants to merge1 commit intoexceljs:masterfromS4RB:master
Closed

Add correct parsing for inline strings#495

robscotts4rb wants to merge1 commit intoexceljs:masterfromS4RB:master

Conversation

@robscotts4rb
Copy link

Inline strings that previously met the XML spec, caused the parsing of the files to fail.

Inline strings that previously met the XML spec, caused  the parsing of the files to fail.
@robscotts4rb
Copy link
Author

@guyonroche I couldn't find the correct place to add tests around parsing of a file. If you can point me in the correct direction I am happy to add them

@guyonroche
Copy link
Collaborator

guyonroche commentedMar 7, 2018
edited
Loading

@robscotts4rb sorry it's taken me so long to get to this.
If you could add some tests that would be fantastic. The best file would be spec/unit/xlsx/xform/sheet/cell-xform.spec.js

Would this mean we should be writing inline strings as

<c t="inlineStr"><t> ... </t></c> ?

Or do you think that might cause more problems than it solves?

@linguamatics-pdenes

@guyonroche I tried to something similar in#501 and added a very basic unit test in there -- hope it makes sense!

@guyonroche
Copy link
Collaborator

@robscotts4rb thanks for the contribution - I'm going to merge#501 and close this one as they are both working to the same end

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robscotts4rb@guyonroche@linguamatics-pdenes

[8]ページ先頭

©2009-2025 Movatter.jp