Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add type definition#490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
guyonroche merged 2 commits intoexceljs:masterfromtaoqf:master
Mar 5, 2018
Merged

add type definition#490

guyonroche merged 2 commits intoexceljs:masterfromtaoqf:master
Mar 5, 2018

Conversation

taoqf
Copy link
Contributor

No description provided.

kachkaev reacted with thumbs up emoji
@Rycochet
Copy link
Contributor

Should reference to#238 and#177 here, and maybe compare contents of my gist linked in it.

@taoqf
Copy link
ContributorAuthor

taoqf commentedFeb 5, 2018
edited
Loading

I just want to help, and I am using this project in my work.

Rycochet, mah110020, kachkaev, ahaverty, and Martin148 reacted with thumbs up emoji

@kachkaev
Copy link

kachkaev commentedFeb 20, 2018
edited
Loading

Having typings forexceljs would be awesome!@guyonroche 🙏

package.json Outdated
"README.md"
]
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ouch 😆

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry for the formatter

kachkaev reacted with thumbs up emoji
@guyonrocheguyonroche merged commit46853d1 intoexceljs:masterMar 5, 2018
@guyonroche
Copy link
Collaborator

Thanks@taoqf for doing this!
I'm not the hugest fan of types in JS but I know a lot of people are :-) so this will be a great addition

kachkaev, jnodev, and ahaverty reacted with hooray emoji

@Purus
Copy link

How should I use this typings for my Typescript application?

@taoqf
Copy link
ContributorAuthor

Just install this lib will be OK, after new version if published.

@Purus
Copy link

Any idea when this will be published? Trying to use in a project.

kachkaev, ahaverty, and graciano reacted with thumbs up emoji

@taoqf
Copy link
ContributorAuthor

ask@guyonroche

@ahaverty
Copy link

@taoqf@guyonroche It looks like this is in the repo and released 👏

But on v1.0.1import * as ExcelJs from 'exceljs'; isn't giving me any types as expected.
I can't find a index.d.ts in the dist after installing either
Has anyone gotten it to work? 🤔

@taoqf
Copy link
ContributorAuthor

@guyonroche , please put index.d.ts in release.

grbspltt and saschanaz reacted with thumbs up emoji

@grbspltt
Copy link

@ahaverty I found the typings in the repo, copied and pasted into the node_modules/exceljs folder. Not a great solution but works until the release is fixed.

@spacem
Copy link

Before this change I was using types fromhttps://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/exceljs
ie. installed withnpm install @types/exceljs

Now I updated to the latest exceljs and the 'official' types from this merge don't seem so good. To give one example the font interface says that font requires all the parameters where I believe actually they should be optional?

@kachkaev
Copy link

@spacem could you please submit a PR that would fix the typing issues you are facing?

@taoqftaoqf mentioned this pull requestJun 26, 2018
@taoqf
Copy link
ContributorAuthor

@spacem anything else?

@spacem
Copy link

spacem commentedJun 26, 2018
edited
Loading

Beat me to the pr.. Maybe others should be partial but I am not using those.
The only other compile error I get now is from streams. The DefinitelyTyped types hadimport { Writable, Stream } from 'stream'; so could pass the result of createInputStream() into stream.pipe()

Thanks guys!

@taoqf
Copy link
ContributorAuthor

@spacem Maybe you should install @types/node for now.
npm install @types/node

I've add this into dependencies.
ad3b792

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
1 more reviewer

@kachkaevkachkaevkachkaev left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@taoqf@Rycochet@kachkaev@guyonroche@Purus@ahaverty@grbspltt@spacem

[8]ページ先頭

©2009-2025 Movatter.jp