- Notifications
You must be signed in to change notification settings - Fork1.9k
add type definition#490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
taoqf commentedFeb 5, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I just want to help, and I am using this project in my work. |
kachkaev commentedFeb 20, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Having typings for |
package.json Outdated
"README.md" | ||
] | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ouch 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry for the formatter
Thanks@taoqf for doing this! |
Purus commentedMar 22, 2018
How should I use this typings for my Typescript application? |
Just install this lib will be OK, after new version if published. |
Purus commentedMar 22, 2018
Any idea when this will be published? Trying to use in a project. |
ask@guyonroche |
ahaverty commentedMar 28, 2018
@taoqf@guyonroche It looks like this is in the repo and released 👏 But on v1.0.1 |
@guyonroche , please put index.d.ts in release. |
grbspltt commentedMar 29, 2018
@ahaverty I found the typings in the repo, copied and pasted into the node_modules/exceljs folder. Not a great solution but works until the release is fixed. |
spacem commentedJun 26, 2018
Before this change I was using types fromhttps://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/exceljs Now I updated to the latest exceljs and the 'official' types from this merge don't seem so good. To give one example the font interface says that font requires all the parameters where I believe actually they should be optional? |
kachkaev commentedJun 26, 2018
@spacem could you please submit a PR that would fix the typing issues you are facing? |
@spacem anything else? |
spacem commentedJun 26, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Beat me to the pr.. Maybe others should be partial but I am not using those. Thanks guys! |
No description provided.