Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bug fix: wb.worksheets/wb.eachSheet caused getWorksheet(0) to return sheet#485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
guyonroche merged 1 commit intoexceljs:masterfrommah110020:master
Feb 28, 2018

Conversation

@mah110020
Copy link

@mah110020mah110020 commentedJan 29, 2018
edited
Loading

wb._worksheets is an array with an empty first element. Calling wb.worksheets or wb.eachSheet called _worksheets.sort() which mutated the array and shifted the sheets into the empty element slot. I am not sure that the mutation was intentional or necessary. My solution no longer mutates _worksheets.

Also added test.

@mah110020mah110020 changed the titlewb.worksheets and wb.eachSheet caused getWorksheet(0) to return sheetBug fix: wb.worksheets/wb.eachSheet caused getWorksheet(0) to return sheetFeb 5, 2018
@guyonrocheguyonroche merged commit020b94e intoexceljs:masterFeb 28, 2018
@guyonroche
Copy link
Collaborator

Nice find - just publishing it now... Thanks@mah110020

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mah110020@guyonroche

[8]ページ先頭

©2009-2025 Movatter.jp