- Notifications
You must be signed in to change notification settings - Fork1.9k
Don't break when loading an Excel file containing a chartsheet#466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
erezny pushed a commit to atriumlts/exceljs that referenced this pull requestJan 2, 2019
commit52ddb6bAuthor: Elliott Rezny <elliott@atrium.co>Date: Mon Dec 31 16:47:16 2018 -0800 buildcommitd924091Author: scott <scott@atriumlts.com>Date: Wed Jan 3 13:14:28 2018 -0800 Missing dist filescommite966e71Author: scott <scott@atriumlts.com>Date: Wed Jan 3 13:13:57 2018 -0800 Remove namespace specific things to parse malformed XMLcommitf6f9cb4Author: scott <scott@atriumlts.com>Date: Tue Jan 2 14:11:38 2018 -0800 Sax shim for XMLNS parsing for importing excel files which have namespaces for whatever reasoncommit66f8c2eAuthor: scott <scott@justmachinery.net>Date: Fri Dec 29 17:27:50 2017 -0800 Build for previous commitcommitce033efAuthor: scott <scott@justmachinery.net>Date: Fri Dec 29 17:27:07 2017 -0800 Tentative fix for malformed app.xmlcommit2a2b091Author: scott <scott@justmachinery.net>Date: Fri Dec 29 16:39:13 2017 -0800 Unignore build/dist to host package on gitcommitb8a21feAuthor: scott <scott@justmachinery.net>Date: Fri Dec 22 19:25:29 2017 -0800 Testing iterative calculation outputcommitf83fad4Author: Guyon <guyon@live.com>Date: Tue Jan 16 20:05:30 2018 +0000 0.8.2commit0eacc22Author: guyon <guyon@live.com>Date: Tue Jan 16 20:04:46 2018 +0000 Doccommitace1e4dMerge:d17b361b9059a3Author: Guyon Roche <guyon@live.com>Date: Tue Jan 16 19:56:06 2018 +0000 Merge pull requestexceljs#471 from robbi/hotfix/sheet_order#257 Hotfix/sheet order#257commitd17b361Merge:3950e0efd0bf4cAuthor: Guyon Roche <guyon@live.com>Date: Tue Jan 16 19:51:08 2018 +0000 Merge pull requestexceljs#466 from peakon/fix/unbreakChartsheet Don't break when loading an Excel file containing a chartsheetcommitb9059a3Author: Olivier Robin <olivier.robin@bpce-it.fr>Date: Sun Jan 7 18:42:58 2018 +0100 Fix linting issuecommit7a53221Author: Olivier Robin <olivier.robin@bpce-it.fr>Date: Sun Jan 7 18:40:14 2018 +0100 Add worksheet order numbercommitdb408fcAuthor: Olivier Robin <olivier.robin@bpce-it.fr>Date: Sun Jan 7 18:39:20 2018 +0100 Add test case for the issueexceljs#257commitfd0bf4cAuthor: Andreas Lind <andreas.lind@peakon.com>Date: Tue Dec 19 14:12:10 2017 +0100 Don't break when loading an Excel file containing a chartsheet Test case found here:http://www.excel-easy.com/examples/excel-files/chart-sheet.xlsx
AlameerAshraf commentedDec 20, 2020
It's still breaking when the excel file contains a chart sheet :( any ideas ! |
yogithesymbian commentedAug 15, 2023
where is documentation to show a chart ? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into a problem where exceljs crashed on a customer-uploaded excel file containing chartsheets. It's an entirely new concept to me, and it looks like exceljs doesn't understand those at the moment, so I chose to do a minimal fix so we don't crash, at least :)
Test case found here:http://www.excel-easy.com/examples/excel-files/chart-sheet.xlsx