- Notifications
You must be signed in to change notification settings - Fork1.9k
Fix #345 TypeError: Cannot read property 'date1904' of undefined#364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| this.model={ | ||
| sheets:this.map.sheets.model, | ||
| properties:this.map.workbookPr.model, | ||
| properties:this.map.workbookPr.model||{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good - could you also add a unit test that catches this issue?
in: spec/unit/xlsx/xform/book/workbook-xform.spec.js
best approach woud be making copies of the spec/unit/xlsx/xform/book/data/book.1.* files and adding a new expectation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry. No, actually I don't know how to add the unit test.
I just fixed an.xlsx file parsed with itsthis.map.workbookPr.model beingundefined causing an null reference error.
This because the file itself having a missing property andexceljs supposing it have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK, I have a little time now, I'll do it
cant open xlsx saved from Numbers
model.properties is undefined