- Notifications
You must be signed in to change notification settings - Fork1.9k
Fix right to left issues#356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| xmlStream.addAttribute(name,value); | ||
| } | ||
| }; | ||
| add('rightToLeft','1',model.rtl===true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
there needs to be a corresponding line in the parseOpen function or it won't be able to read files properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also - could you add this property to the unit test:
in spec/unit/xlsx/xform/sheet/sheet-view-xform.spec.js
| {k:'l2r',v:2}, | ||
| {k:Enums.ReadingOrder.RightToLeft,v:1}, | ||
| {k:Enums.ReadingOrder.LeftToRight,v:2} | ||
| {k:'rtl',v:2}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would you be able to add a unit test for these changes?
in spec/unit/xlsx/xform/style/alignment-xform.spec.js
@guyonroche I made the requested changes. I also renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
pouyakary commentedDec 31, 2023
@alitaheri what a small world! |
Adds a new property to sheet view. And fixes
readingOrderas it wasn't doing anything for 2 reasons:l2randr2linstead of the documentltrandrtlones.Closes#72
Closes#126