- Notifications
You must be signed in to change notification settings - Fork1.9k
Issue 296#343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Issue 296#343
Uh oh!
There was an error while loading.Please reload this page.
Conversation
package.json Outdated
| { | ||
| "name":"exceljs", | ||
| "version":"0.4.12", | ||
| "version":"0.4.13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Bumping the package version is managed by the release scripts (npm version patch, etc). Please can you revert this line
| xmlEncode:function(text){ | ||
| // eslint-disable-next-line no-control-regex | ||
| returntext.replace(/[<>&'"\x7F\x00-\x08\x0A-\x0C\x0E-\x1F]/g,function(c){ | ||
| returntext.replace(/[<>&'"\x7F\x00-\x08\x0B-\x0C\x0E-\x1F]/g,function(c){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you also add a unit test for this (in spec/unit/utils/utils.spec.js to ensure \x0a is retained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Weird that the previous PR that was supposed to fix this same issue wasn't required to have a unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I had a lot more spare time then. Thanks for doing this - I'll publish tonight.
Let new lines through xmlEncode function. See github issue 296 (#296).