- Notifications
You must be signed in to change notification settings - Fork1.9k
Removed critical vulnerabilities from the package.#2999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
peterv959 wants to merge2 commits intoexceljs:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+31 −42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
typescript: 3.9.10 → 5.9.3ts-node: 8.10.2 → 10.9.2mocha: 7.2.0 → 11.7.5 (brings glob 7.1.3 → 10.4.5)@types/mocha: 8.0.3 → 10.0.10@types/node: 14.18.63 → 24.10.0@types/chai: 4.3.20 → 5.2.3regenerator-runtime: 0.13.11 → 0.14.1saxes: 5.0.1 → 6.0.0unzipper: 0.10.14 → 0.12.3browserify: 16.5.2 → 17.0.1grunt-browserify: 5.3.0 → 6.0.0grunt-contrib-jasmine: 2.2.0 → 4.0.0grunt-terser: 1.0.0 → 2.0.0Removed grunt-exorcise as modern browsers handle inline maps now.Fixed: TypeScript test using deprecated APIVulnerabilities reduced from 37 to 19 with remaining all dev related.There are still two failing integration tests, but they existed before.
…light, which has a memory leak issue.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There were quite a few critical vulnerabilities which make me nervous. Granted, they were in the devDependencies, but I still get nervous. This reduced the vulnerabilities from 37 to 19. All tests pass with three exceptions. These three failing tests pre-existed.
Test plan
The output from the
npm run test:fulltest-results.txt
Related to source code (for typings update)