- Notifications
You must be signed in to change notification settings - Fork1.9k
Fix a constant identifier naming error in the Chinese documentation#2912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
yusn wants to merge1 commit intoexceljs:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
protobi-pieter commentedNov 8, 2025
谢谢你修复这个命名不一致的问题！🎉 (Thanks for fixing this naming inconsistency!) Your fix improves code consistency in the Chinese documentation. We've adopted this into our actively maintained fork athttps://github.com/protobi/exceljs. Your contribution is appreciated and credited in commit 2d1ddcf. |
protobi-pieter added a commit to protobi/exceljs that referenced this pull requestNov 8, 2025
…ng consistencyFixes variable naming inconsistency in WorkbookReader example:declares 'workbook' but uses 'workbookReader' in the loop.Changed to consistently use 'workbookReader' throughout the example.Original PR:exceljs#2912Original Author: yusn (余森)🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>Co-Authored-By: yusn <yusn@foxmail.com>
protobi-pieter added a commit to protobi/exceljs that referenced this pull requestNov 8, 2025
- Mark 4 documentation PRs as merged (commits 30b9971, 8558d21, af8abfc, 2d1ddcf) -exceljs#2783: Fix image embedding docs -exceljs#2733: Fix broken example code -exceljs#2577: Fix tabColor example -exceljs#2912: Fix Chinese docs variable name- Convert all PR numbers to clickable hyperlinks pointing to upstream exceljs/exceljs- Convert all Issue numbers to clickable hyperlinks pointing to fork protobi/exceljsThis makes the document more navigable and tracks our progress on documentation improvements.🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a constant identifier naming error in the Chinese documentation。
Test plan
Related to source code (for typings update)