- Notifications
You must be signed in to change notification settings - Fork1.9k
📝 Fix errors in document about image embedding#2783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Cat7373 wants to merge1 commit intoexceljs:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+17 −17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
protobi-pieter commentedNov 8, 2025
Thanks for this important documentation fix! 🎉 We've adopted this change into our actively maintained fork athttps://github.com/protobi/exceljs. Your contribution fixes real user confusion about image embedding behavior and aligns the docs with Microsoft's official OpenXML documentation. Your work is appreciated and credited in commit 30b9971. Thanks for taking the time to improve the documentation! |
protobi-pieter added a commit to protobi/exceljs that referenced this pull requestNov 8, 2025
…ion errorsFixes documentation inconsistencies between Chinese/English docs and actual code behavior:- Corrects editAs value names: 'twoCells'/'oneCells' → 'twoCell'/'oneCell' (plural to singular)- Changes 'undefined' to 'twoCell' as the correct value for move-and-resize behavior- Updates examples to show proper Anchor constructor usage- Fixes default value documentation (was incorrectly listed as 'absolute', actually 'oneCell')This addresses Issuesexceljs#2730 andexceljs#1747 and aligns with Microsoft's official OpenXML documentation.Original PR:exceljs#2783Original Author: Cat7373 (@cat73)🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>Co-Authored-By: Cat73 <cat7373@gmail.com>
protobi-pieter added a commit to protobi/exceljs that referenced this pull requestNov 8, 2025
- Mark 4 documentation PRs as merged (commits 30b9971, 8558d21, af8abfc, 2d1ddcf) -exceljs#2783: Fix image embedding docs -exceljs#2733: Fix broken example code -exceljs#2577: Fix tabColor example -exceljs#2912: Fix Chinese docs variable name- Convert all PR numbers to clickable hyperlinks pointing to upstream exceljs/exceljs- Convert all Issue numbers to clickable hyperlinks pointing to fork protobi/exceljsThis makes the document more navigable and tracks our progress on documentation improvements.🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the current documentation, the Chinese and English documents are inconsistent. One uses oneCell, the other uses oneCells. One says absolute is the default value, the other says oneCell is the default value. In addition, passing undefined in the English document is invalid because it will match the default value oneCell.
Fixed the inconsistency between the image embedding part in the document and the actual code. Please refer to the following Issue:
#2730
#1747
Please also refer to the documentation from Microsoft:
https://learn.microsoft.com/en-us/dotnet/api/documentformat.openxml.drawing.spreadsheet.editasvalues?view=openxml-3.0.1
Test plan
From my project code, it works correctly: