Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Minor fixes for stream handling#267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
guyonroche merged 2 commits intoexceljs:masterfrompeakon:stream_fixes
Mar 10, 2017

Conversation

@holm
Copy link
Contributor

I upgraded from 0.2.38 to 0.2.46 today, and a few of our testcases failed. I tracked it down to two issues:

  • The catch handler on the zip parsing was missing, and also wasn't propagating the error via the event emitter.
  • The workbook writer was resolving the write when the zip-stream was done, not when the underlying stream was done. This meant that the write could resolve, while f.ex. a file was still being written to disk.

@neuralp
Copy link

Thank you for this simple fix. I was just trying to figure out why my catch wasn't working while passing bad files to the readFile function and behold, you have the answer!

@guyonroche
Copy link
Collaborator

@holm - you wouldn't be able to add one of those failing test cases (or a smaller version of one) would you?
This (or something related to it) has been a recurring issue and it would be good to prevent it from happening again.

@holm
Copy link
ContributorAuthor

I can try to find the time next week. I just needed it fixed quite urgently for one of our customers, but I should have time soon.

@guyonrocheguyonroche merged commit17f24b6 intoexceljs:masterMar 10, 2017
@guyonroche
Copy link
Collaborator

@holm - Just looking into this now, I hope to publish this weekend. I just noticed the change in zip-stream removed the .catch() on entry.async(), was that necessary or is it just that entry.async() doesn't reject?

@holm
Copy link
ContributorAuthor

Yeah, that looks like a mistake. Should most likely emit the error there also.

@guyonroche
Copy link
Collaborator

@holm Cool - thanks.
I've restored the other catch.
All tests passing with this and the updated lib versions so I've just published => 0.3.1.

@holm
Copy link
ContributorAuthor

Thanks a lot for all your work on this library, it's pretty great!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@holm@neuralp@guyonroche

[8]ページ先頭

©2009-2025 Movatter.jp