- Notifications
You must be signed in to change notification settings - Fork1.9k
Minor fixes for stream handling#267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
neuralp commentedFeb 23, 2017
Thank you for this simple fix. I was just trying to figure out why my catch wasn't working while passing bad files to the readFile function and behold, you have the answer! |
guyonroche commentedFeb 23, 2017
@holm - you wouldn't be able to add one of those failing test cases (or a smaller version of one) would you? |
holm commentedFeb 23, 2017
I can try to find the time next week. I just needed it fixed quite urgently for one of our customers, but I should have time soon. |
guyonroche commentedMar 10, 2017
@holm - Just looking into this now, I hope to publish this weekend. I just noticed the change in zip-stream removed the .catch() on entry.async(), was that necessary or is it just that entry.async() doesn't reject? |
holm commentedMar 10, 2017
Yeah, that looks like a mistake. Should most likely emit the error there also. |
guyonroche commentedMar 10, 2017
@holm Cool - thanks. |
holm commentedMar 10, 2017
Thanks a lot for all your work on this library, it's pretty great! |
I upgraded from 0.2.38 to 0.2.46 today, and a few of our testcases failed. I tracked it down to two issues: