NotificationsYou must be signed in to change notification settings
Fork1.9k
Star14.8k

Parse page breaks#2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

kigh-ota wants to merge3 commits intoexceljs:master

base:master

Choose a base branch

fromkigh-ota:load-page-breaks

Open

Parse page breaks#2602

kigh-ota wants to merge3 commits intoexceljs:masterfromkigh-ota:load-page-breaks

Conversation

Copy link

Contributor

kigh-ota commentedNov 26, 2023

Summary

Reads and parses page breaks into the model.
Previously#1257 added support for writing page breaks, but not for reading/parsing.

Fixes#2249.

Test plan

// Create 1.xlsx that contains a page breakconstwb1=newExcel.Workbook();constws1=wb1.addWorksheet('row-breaks');ws1.getCell('A1').value='A1';ws1.getCell('A2').value='A2';ws1.getCell('A3').value='A3';ws1.getCell('A4').value='A4';ws1.getRow(2).addPageBreak();awaitwb1.xlsx.writeFile('./1.xlsx');// Read 1.xlsx and write to 2.xlsxconstwb2=newExcel.Workbook();awaitwb2.xlsx.readFile('./1.xlsx');console.log(wb2.getWorksheet('row-breaks').rowBreaks);// returns an array of length 1awaitwb2.xlsx.writeFile('./2.xlsx');