Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix: Sheet Properties Types#2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Siemienik merged 3 commits intoexceljs:masterfromalbeniraouf:master
Aug 23, 2023
Merged

Conversation

albeniraouf
Copy link
Contributor

@albeniraoufalbeniraouf commentedAug 4, 2023•
edited by Siemienik
Loading

Summary

Test plan

Related to source code (for typings update)

preparedModel:{outlineProperties:{summaryBelow:false}},

outlineProperties:properties&&properties.outlineProperties,

outlineProperties:model.properties&&model.properties.outlineProperties,

@albeniraouf
Copy link
ContributorAuthor

@Siemienik please consider reviewing the PR and release ASAP as it breaks our code and requires using "any" type which is not correct

@zurmokeeper
Copy link
Contributor

zurmokeeper commentedAug 4, 2023•
edited by Siemienik
Loading

@albeniraouf Could you please moveover here? I'd be happy to merge this feature.

Copy link
Member

@SiemienikSiemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@SiemienikSiemienik merged commit8a84db2 intoexceljs:masterAug 23, 2023
@Siemienik
Copy link
Member

Thank you@albeniraouf. that's good patch 👍

albeniraouf reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SiemienikSiemienikSiemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@albeniraouf@zurmokeeper@Siemienik
[8]ページ先頭
©2009-2025 Movatter.jp