Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Increase resilience to generating large workbooks#2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Siemienik merged 3 commits intoexceljs:masterfromhfhchan-plb:fix-large-file-export
Sep 19, 2023

Conversation

hfhchan-plb
Copy link
Contributor

Summary

Updates the xml-stream.js to generate a single string instead of multiple strings for each attribute or record of attributes.

Closes:#2303

Increase resilience to generating large workbooks
@hfhchan-plb
Copy link
ContributorAuthor

hfhchan-plb commentedAug 1, 2023•
edited
Loading

@zurmokeeper I renamed the branch on my local repo and GitHub automatically closed#2319. So I needed to create a PR again. Sorry for the inconvenience.

@hfhchan-plbhfhchan-plb changed the titleUpdate xml-stream.jsIncrease resilience to generating large workbooksAug 1, 2023
@zurmokeeper
Copy link
Contributor

@hfhchan-plb Could you please moveover here? I'd be happy to merge this feature.

@hfhchan-plb
Copy link
ContributorAuthor

hfhchan-plb commentedAug 6, 2023•
edited
Loading

@zurmokeeper I don't mind if you wish to cherry pick to your fork, with or without accreditation.

We are currently using our own fork for excel generation which is tracking upstream, so we are unlikely to move to a fork unless there is a good guarantee of maintainability, or a large technical benefit (i.e. completely rewritten in TypeScript, using Web Streams API, no dependencies on outdated libraries, etc).

@Siemienik
Copy link
Member

Siemienik commentedSep 19, 2023•
edited
Loading

Sorry for some inconvenience recently, now I'm able to resume active development - more info would be found in a topic about next release v4.4.0:#2352

hfhchan-plb reacted with thumbs up emoji

Copy link
Member

@SiemienikSiemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good stuff, Thank you@hfhchan-plb

@SiemienikSiemienik merged commit804775a intoexceljs:masterSep 19, 2023
@hfhchan-plbhfhchan-plb deleted the fix-large-file-export branchSeptember 20, 2023 06:16
gltjk added a commit to gltjk/excelize that referenced this pull requestFeb 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SiemienikSiemienikSiemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Out-of-memory with lots of cells
3 participants
@hfhchan-plb@zurmokeeper@Siemienik
[8]ページ先頭
©2009-2025 Movatter.jp