Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

do not skip empty string in shared strings so that indexes match#232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
guyonroche merged 1 commit intoexceljs:masterfrompookong:do_not_skip_empty_shared_string
Dec 2, 2016
Merged

do not skip empty string in shared strings so that indexes match#232

guyonroche merged 1 commit intoexceljs:masterfrompookong:do_not_skip_empty_shared_string
Dec 2, 2016

Conversation

pookong
Copy link

when working with shared strings this library adds empty string into shared strings (as it should), but when the shared strings are processed into xml, the empty string is omitted

workbook with cells['foo', '', 'bar'] createsxl/sharedStrings.xml like:

<sst xmlns="..." count="3" uniqueCount="3">  <si><t>foo</t></si>  <si/>  <si><t>bar</t></si></sst>

with missing<t> tag in<si>

this results in missing shared string in some excel reading libs that do not count this<si> as a string

when the sheet is opened and resaved with MS Excel, the shares string includes an empty<t> tag

@guyonrocheguyonroche merged commit202593a intoexceljs:masterDec 2, 2016
@guyonroche
Copy link
Collaborator

Good catch! Thanks again for the contribution

@pookong
Copy link
Author

thanks for merging... and for the whole lib - it surely pulled a thorn out of my foot :D

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@pookong@guyonroche

[8]ページ先頭

©2009-2025 Movatter.jp