Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: fix type definitions about last column, formula values and protection#2309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Siemienik merged 4 commits intoexceljs:masterfromgltjk:type-fix
Sep 19, 2023

Conversation

@gltjk
Copy link
Contributor

@gltjkgltjk commentedJul 18, 2023
edited
Loading

Summary

Several type definition has been fixed. Details:

  • Worksheet.lastColumn can beundefined for an empty worksheet, asWorksheet.lastRow can beundefined.
  • date1904 should be an optional property for bothCellFormulaValue andCellSharedFormulaValue.
  • CellFormulaValue.result andCellSharedFormulaValue.result should includeboolean.
  • CellFormulaValue.result andCellSharedFormulaValue.result should includeCellErrorValue, not{ error: CellErrorValue }, becauseCellErrorValue itself is already an interface witherror as its property.
  • Protection should have ahidden property, as is recorded in the documentation.
  • dashed should be a valid value forBorderStyle, as is documented in ISO/IEC 29500-1:2016 18.18.3 ST_BorderStyle (Border Line Styles).

Test plan

Related to source code (for typings update)

Copy link
Member

@SiemienikSiemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks

gltjk reacted with hooray emoji
@SiemienikSiemienik merged commitbd317db intoexceljs:masterSep 19, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SiemienikSiemienikSiemienik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gltjk@Siemienik

[8]ページ先頭

©2009-2025 Movatter.jp