Movatterモバイル変換

Skip to content

exceljs/exceljsPublic

NotificationsYou must be signed in to change notification settings
Fork1.9k
Star15k

Improve worksheets' naming validation logic.#2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Siemienik merged 6 commits intoexceljs:masterfromSiemaTeam:issue-2243

May 5, 2023

Merged

Improve worksheets' naming validation logic.#2257

Siemienik merged 6 commits intoexceljs:masterfromSiemaTeam:issue-2243

May 5, 2023

Conversation

@Siemienik

Copy link

Member

Siemienik commentedApr 26, 2023•
edited
Loading

Summary

This PR aims toresolve#2243 issue.
Additionally, I transferred the responsibility for name validation fromWorkbook toWorksheet, which allowed me to tighten the rules for changing the name using:ws.name

Test plan

I completed the missing tests and covers all new assertions.

@Siemienik

move worksheet's name validation logic from workbook to worksheet object

1100c02

@Siemienik

Siemienik self-assigned this

Siemienik added4 commits

April 26, 2023 22:03

@Siemienik

revertexceljs#2126

fa513f8

@Siemienik

cover ws.name setter with tests

90458ff

@Siemienik

protect again set ws name 'History'

04de8a9

@Siemienik

block empty ws names

5d3b058

@Siemienik

Siemienik marked this pull request as ready for review

April 27, 2023 08:28

@Siemienik

remove redundant tests, improve error message

960fa73

@Siemienik

Siemienik changed the title~~Improve worksheet's naming validation logic.~~Improve worksheets' naming validation logic.

@Siemienik

Copy link

MemberAuthor

Siemienik commentedMay 5, 2023

This PR was reviewed during the MergeFest session.
To join the next one please follow to SiemaTeam's Discord server:

You can also support my OpenSource activity bysponsoring me

@Siemienik

Siemienik merged commit887983a intoexceljs:master

@Siemienik

Siemienik deleted the issue-2243 branch

May 5, 2023 12:05

@Siemienik

Siemienik mentioned this pull request

Found problem with some content#1366

Open

@j-mendez

j-mendez mentioned this pull request

[Snyk] Upgrade: apollo-server-core, apollo-server, apollo-server-fastify, , , , , cron, date-fns, exceljs, fastq, fastify, graphql, graphql-middleware, ioredis, graphql-redis-subscriptions, graphql-ws, mongodb, node-iframe, nodemailer, wsa11ywatch/core#431

Open

@Vishwas1

Vishwas1 mentioned this pull request

[Snyk] Upgrade: cookie-parser, exceljs, express, express-validator, node-fetch, https-localhost, nodemailer, hypersign-auth-js-sdk, mongoose, url-parse, web3hypersign-protocol/hyperfyre-frontend#1979

Open

@j-mendez

j-mendez mentioned this pull request

[Snyk] Upgrade: apollo-server-core, apollo-server, apollo-server-fastify, , , , , cron, date-fns, exceljs, fastq, fastify, graphql, graphql-middleware, ioredis, graphql-redis-subscriptions, graphql-ws, mongodb, node-iframe, nodemailer, wsa11ywatch/core#433

Open

This was referencedSep 15, 2024

[Snyk] Upgrade: cookie-parser, exceljs, express, express-validator, node-fetch, https-localhost, nodemailer, hypersign-auth-js-sdk, mongoose, url-parse, web3hypersign-protocol/hyperfyre-frontend#1980

Open

[Snyk] Upgrade: cookie-parser, exceljs, express, express-validator, node-fetch, https-localhost, nodemailer, hypersign-auth-js-sdk, mongoose, url-parse, web3hypersign-protocol/hyperfyre-frontend#1981

Open

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

1 participant

@Siemienik

[8]ページ先頭

©2009-2025 Movatter.jp