Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix output order of Sheet Properties#225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
guyonroche merged 1 commit intoexceljs:masterfromkeeneym:TabColorFix
Dec 2, 2016

Conversation

keeneym
Copy link

@keeneymkeeneym commentedNov 11, 2016
edited
Loading

I noticed that when using both "tabColors" and "sheetViews" the resulting xlsx files end up being corrupt when trying to open in Microsoft Excel. After playing around a bit in the zip files I realized Excel is pretty picky about element order in the xml files, and it prefers to have the Sheet Properties before the Sheet Views.

Here is some example code that is corrupt before my change and opens fine after:

var wb = new Excel.stream.xlsx.WorkbookWriter({filename: "tabColorTest.xlsx", useSharedStrings: true});var ws = wb.addWorksheet('blort', {    properties: {        tabColor: {argb: 'FFFF0000'}    },    views: [        {            state: 'frozen',            ySplit: 1,            topLeftCell:"A2"        }    ]});ws.getCell('A1').value = "frozenHeader";ws.getCell('A2').value = "tabColorTest";wb.commit();

chenop reacted with thumbs up emoji
@keeneym
Copy link
Author

@guyonroche Was I supposed to create an Issue for this? I'm a bit new to github, I'm not sure if you see incoming Pull Requests.

@guyonrocheguyonroche merged commitaaca364 intoexceljs:masterDec 2, 2016
@guyonroche
Copy link
Collaborator

@keeneym no need for an issue. Thanks for the contribution.

keeneym reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@keeneym@guyonroche

[8]ページ先頭

©2009-2025 Movatter.jp