Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Fix xlsx.writeFile() not catching error when error occurs#2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Siemienik merged 4 commits intoexceljs:masterfromzurmokeeper:bugfix/writeFileError
Apr 24, 2023

Conversation

zurmokeeper
Copy link
Contributor

@zurmokeeperzurmokeeper commentedApr 14, 2023•
edited
Loading

Summary

Whenawait workbook.xlsx.writeFile(filename).
was reported, but the error was not caught by try catch, after modifying the source code, it can now be caught

Test plan

try {    const imageId2 = workbook.addImage({        buffer: fs.readFileSync('path/to.image.png'),        extension: 'png',      });    await workbook.xlsx.writeFile(filename);} catch (error) {    console.log(error)}

Related to source code (for typings update)

Copy link
Member

@SiemienikSiemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch, looks good for me, but test case is required before merge

@zurmokeeper
Copy link
ContributorAuthor

Good catch, looks good for me, but test case is required before merge

Great, I will add the test cases later

Siemienik reacted with hooray emoji

@zurmokeeper
Copy link
ContributorAuthor

@Siemienik Additional test cases have been added

Siemienik reacted with hooray emoji

Copy link
Member

@SiemienikSiemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks

@SiemienikSiemienik merged commit77e549a intoexceljs:masterApr 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SiemienikSiemienikSiemienik approved these changes

+1 more reviewer

@naorpelednaorpelednaorpeled approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@zurmokeeper@Siemienik@naorpeled@CTyrannosaurus
[8]ページ先頭
©2009-2025 Movatter.jp