- Notifications
You must be signed in to change notification settings - Fork1.9k
Fix types for getWorksheet()#2223
Merged
Siemienik merged 3 commits intoexceljs:masterfromApr 13, 2023
Merged
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Siemienik approved these changesApr 6, 2023
Member
Siemienik left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hello, hello@hfhchan-plb . It looks good to me. Thanks:tada:.
Additionally, I spot and update the paramindexOrName to optional. Following the source code, ifindexOrName is undefined, the function returns the first worksheet.
This was referencedApr 6, 2023
Member
Siemienik commentedApr 6, 2023
Tests on node v8 failed. I will fix them before the final merge: |
Siemienik approved these changesApr 13, 2023
Member
Siemienik left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
naorpeled approved these changesApr 13, 2023
This was referencedSep 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix types for getWorksheet(). It can return undefined
Test plan
N/A
Related to source code (for typings update)
lib/doc/workbook.js#L143