- Notifications
You must be signed in to change notification settings - Fork1.9k
Fix types for getWorksheet()#2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hello, hello@hfhchan-plb . It looks good to me. Thanks:tada:.
Additionally, I spot and update the paramindexOrName to optional. Following the source code, ifindexOrName is undefined, the function returns the first worksheet.
Tests on node v8 failed. I will fix them before the final merge: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Summary
Fix types for getWorksheet(). It can return undefined
Test plan
N/A
Related to source code (for typings update)
lib/doc/workbook.js#L143