NotificationsYou must be signed in to change notification settings
Fork1.9k
Star14.8k

fix: fix the loss of column attributes due to incorrect column order#2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Siemienik merged 2 commits intoexceljs:masterfromcpaiyueyue:master

May 5, 2023

Merged

fix: fix the loss of column attributes due to incorrect column order#2222

Siemienik merged 2 commits intoexceljs:masterfromcpaiyueyue:master

May 5, 2023

Conversation

Copy link

Contributor

cpaiyueyue commentedMar 2, 2023

When I try to read the excel file and display it on the page, I found that the hidden columns of some files were not parsed correctly.

Summary

I found that if the order of the column data parsed here is not positive, the subsequent attributes will be overwritten

Test plan

Before modification

After modification

fix: fix the loss of column attributes due to incorrect column order

0680219

Siemienik self-assigned this

Apr 6, 2023

Siemienik assignedSiemienik and unassignedSiemienik

Apr 25, 2023

tanvirstreame approved these changes

Apr 27, 2023

View reviewed changes

Copy link

tanvirstreame commentedApr 27, 2023•
edited
Loading

You have 1 unnecessary commit, Please rebase this branch

Copy link

ContributorAuthor

cpaiyueyue commentedApr 28, 2023•
edited
Loading

You have 1 unnecessary commit, Please rebase this branch

I have already processed it, please check again

Siemienik approved these changes

May 5, 2023

View reviewed changes

Copy link

Member

Siemienik left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🥇 Looks good to me, Thank you for the contribution!

This PR was reviewed during theMergeFest session.

Siemienik force-pushed themaster branch 6 times, most recently fromdd0294a to0680219Compare

May 5, 2023 12:20

Merge branch 'master' into master

a52b7c0

Siemienik merged commitec92cb3 intoexceljs:master

May 5, 2023

Copy link

Member

Siemienik commentedMay 5, 2023•
edited
Loading

You have 1 unnecessary commit, Please rebase this branch

@tanvirstreame
Sorry, but the additional commit is required to make me able to merge - the branch has to be up-to-date, and during MergeFest I usually merge some PRs, each updates themaster making others PRs outdated.

Copy link

ContributorAuthor

cpaiyueyue commentedMay 6, 2023 via email

I'm very sorry, I found that the username I submitted does not match the information I registered on GitHub. Can you use the following code to reset my submission information：#!/bin/shgit filter-branch --env-filter '***@***.***"CORRECT_NAME="cpaiyueyue"***@***.***"if [ "$GIT_COMMITTER_EMAIL" = "$OLD_EMAIL" ]then   export GIT_COMMITTER_NAME="$CORRECT_NAME"   export GIT_COMMITTER_EMAIL="$CORRECT_EMAIL"fiif [ "$GIT_AUTHOR_EMAIL" = "$OLD_EMAIL" ]then   export GIT_AUTHOR_NAME="$CORRECT_NAME"   export GIT_AUTHOR_EMAIL="$CORRECT_EMAIL"fi' --tag-name-filter cat -- --branches --tags 恋海蓝***@***.*** 

…

------------------ 原始邮件 ------------------发件人: "Siemienik ***@***.***>;发送时间: 2023年5月5日(星期五) 晚上9:09收件人: ***@***.***>;抄送: ***@***.***>; ***@***.***>;主题: Re: [exceljs/exceljs] fix: fix the loss of column attributes due to incorrect column order (PR#2222)You have 1 unnecessary commit, Please rebase this branch@tanvirstreame Sorry, but the additional commit is required to make me able to merge - the branch has to be up-to-date, and during MergeFest I usually merge some PRs, each updates the master making others PRs outdated.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>