Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add characters cannot be used for worksheet name#2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

tkm-kj
Copy link
Contributor

@tkm-kjtkm-kj commentedAug 31, 2022
edited
Loading

Summary

As for worksheet name, it raises error if worksheet name contains followings characters now

'*','?',':','/','\\','[',']'

I expect this implementation prevents worksheet from breaking
But, if these characters are full-width characters, the worksheet is broken

Screen.Recording.2022-08-31.at.10.51.50.mov

So, I fixed the issue

Test plan

Code example is below

importExcelJSfrom'exceljs';constworkbook=newExcelJS.Workbook()workbook.addWorksheet('?')

If error raises, the test is success

Related to source code (for typings update)

@tkm-kjtkm-kj marked this pull request as ready for reviewAugust 31, 2022 01:57
@SiemienikSiemienik self-assigned thisApr 6, 2023
Copy link
Member

@SiemienikSiemienik left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thank you. I think we should check if else characters are incorrect. I suppose there is only a narrow range of allowed characters. Will create an investigation ticket for that. (#2243)

@SiemienikSiemienik merged commit478e2a0 intoexceljs:masterApr 14, 2023
Siemienik added a commit to SiemaTeam/Spreadsheets that referenced this pull requestApr 26, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SiemienikSiemienikSiemienik approved these changes

+2 more reviewers

@naorpelednaorpelednaorpeled approved these changes

@coder-xiaotiancoder-xiaotiancoder-xiaotian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@SiemienikSiemienik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@tkm-kj@Siemienik@naorpeled@coder-xiaotian

[8]ページ先頭

©2009-2025 Movatter.jp