- Notifications
You must be signed in to change notification settings - Fork1.9k
add characters cannot be used for worksheet name#2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Siemienik merged 2 commits intoexceljs:masterfromtkm-kj:add-characters-cannot-be-used-for-worksheet-nameApr 14, 2023
Merged
add characters cannot be used for worksheet name#2126
Siemienik merged 2 commits intoexceljs:masterfromtkm-kj:add-characters-cannot-be-used-for-worksheet-nameApr 14, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
coder-xiaotian approved these changesApr 14, 2023
Siemienik approved these changesApr 14, 2023
Member
Siemienik left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thank you. I think we should check if else characters are incorrect. I suppose there is only a narrow range of allowed characters. Will create an investigation ticket for that. (#2243)
naorpeled approved these changesApr 14, 2023
Siemienik added a commit to SiemaTeam/Spreadsheets that referenced this pull requestApr 26, 2023
This was referencedSep 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
As for worksheet name, it raises error if worksheet name contains followings characters now
I expect this implementation prevents worksheet from breaking
But, if these characters are full-width characters, the worksheet is broken
Screen.Recording.2022-08-31.at.10.51.50.mov
So, I fixed the issue
Test plan
Code example is below
If error raises, the test is success
Related to source code (for typings update)