Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix issue #1753 Reject promise when workbook reader is writing to temporary file stream and error occurs#1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Siemienik merged 4 commits intoexceljs:masterfrompauliusg:fix/issue-1753
Apr 14, 2023

Conversation

pauliusg
Copy link
Contributor

Summary

Fixes issue#1753

Workbook code which is creating temporary file by using write stream is not watching for error event, so in case of error promise was not resolved and code stays in hanging state.

@SiemienikSiemienik self-requested a reviewNovember 18, 2021 00:35
@SiemienikSiemienik self-assigned thisApr 6, 2023
@pauliusg
Copy link
ContributorAuthor

Why this one is still not merged?

@Siemienik
Copy link
Member

Hello hello@pauliusg , for quite a long time none of the maintainers had enough time to properly take care of this project. Especially since it is being created voluntarily in their free time. Thank you very much for your contribution, and I will try to merge this PR as soon as possible.
By the way, yesterday we did our first "MergeFest" and there were 3 of us on the online stream. Today we plan to merge more PRs. It would be great if you could join us, you could guide us through this PR and the review would be much easier :)
Link to the event on DISCORD, on time: 3PM CEST
I also invite you to join the community on our serverhttps://discord.gg/SNEtBKPUxE

Have a nice day! :)

@pauliusg
Copy link
ContributorAuthor

pauliusg commentedApr 14, 2023•
edited
Loading

@Siemienik thanks for response. It is good to know that project is still alive! Unfortunately I can't join you, but this PR is very simple one-liner to properly handle stream errors. More context is in issue:#1753

Siemienik reacted with rocket emoji

Copy link
Member

@SiemienikSiemienik left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I really appreciate your contribution, thank you :)

@SiemienikSiemienik merged commit4acab1d intoexceljs:masterApr 14, 2023
Copy link

@coder-xiaotiancoder-xiaotian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SiemienikSiemienikSiemienik approved these changes

+2 more reviewers

@coder-xiaotiancoder-xiaotiancoder-xiaotian left review comments

@naorpelednaorpelednaorpeled approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@SiemienikSiemienik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@pauliusg@Siemienik@naorpeled@coder-xiaotian
[8]ページ先頭
©2009-2025 Movatter.jp