Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added timeouts to github actions#1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

alexbjorlig
Copy link
Contributor

Summary

No need for actions running hour after hour - doing nothing 🌎 ☘️

@SiemienikSiemienik self-requested a reviewNovember 18, 2021 00:38
@Siemienik
Copy link
Member

There is no problem with a never-ending timeout, so I don't see the value of these changes. Could you explain your motivation?

@cclauss
Copy link
Contributor

Global warming?!? Why cook the planet with tests that do not deliver value?

alexbjorlig reacted with thumbs up emoji

Copy link
Member

@SiemienikSiemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We have never situation like that. But ok, for the same reason, there are no concerns to introduce timeouts.

If are you really care about global warming, feel invited to open a PR with performance optimization. This will affect for much more apps than only a few actions.

@SiemienikSiemienik merged commit4d71b66 intoexceljs:masterNov 21, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SiemienikSiemienikSiemienik approved these changes

+1 more reviewer

@cclausscclausscclauss approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@alexbjorlig@Siemienik@cclauss

[8]ページ先頭

©2009-2025 Movatter.jp