- Notifications
You must be signed in to change notification settings - Fork1.9k
Added Node v16 to the test suite#1731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you
Should I add some timeouts to the Github actions, so they don't run for more than x minutes? |
Yeah, it a good idea. Test runner sometimes gets stuck. I have no idea why, so the timeout will work fine. |
@Siemienik I created one here#1733. When this PR is merged, could you provide me with some basic help to get a failing test up and running? Because the simple writable stream example from the Read.me does not work with Node.js v16 🧐 |
Summary
v16 is a new major version of Node.js, let's make sure to add test case of this.
Related to (at least) issue#1594