- Notifications
You must be signed in to change notification settings - Fork1.9k
fix issue 1676#1701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
fix issue 1676#1701
Changes from12 commits
Commits
Show all changes
13 commits Select commitHold shift + click to select a range
56f5a75
Merge remote-tracking branch 'source/master'
skypesky64dd9f2
Merge remote-tracking branch 'source/master'
skypeskyf892881
Merge remote-tracking branch 'source/master'
skypesky0ef8b22
Merge remote-tracking branch 'source/master'
skypesky8ddfad4
Merge branch 'master' of https://github.com/exceljs/exceljs
skypesky6463bbc
Merge branch 'master' of https://github.com/exceljs/exceljs
skypeskybe63395
fix issue 1676 Broken internal link on Google sheets
skypesky59036b7
Update hyperlink-xform.js
skypeskydabaf05
Merge branch 'master' into master
skypesky66e09b8
Merge branch 'master' into master
Siemienikd7b6798
fix(issue 1676): add unit test
65bfb13
Merge branch 'master' into master
364a01b
Merge branch 'master' into master
SiemienikFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
29 changes: 24 additions & 5 deletionslib/xlsx/xform/sheet/hyperlink-xform.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletionsspec/unit/xlsx/xform/sheet/hyperlink-xform.spec.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.