Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

(docs): set prototype of RegExp correctly.#1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Siemienik merged 3 commits intoexceljs:masterfromjolyndenning:ie11-prototype-fix
Nov 18, 2021

Conversation

jolyndenning
Copy link

Summary

Today myself and others diagnosed an issue related tothe documentation for IE11.

The existing documentation is incorrect because it changes the RegExp function such thatRegExp.prototype.exec is no longer defined. After the exceljs IE11 polyfill, one must useRegExp.prototype.prototype.exec instead ofRegExp.prototype.exec when trying to call exec directly. The reason is thatRegExp.prototype is set toRegExp instead ofRegExp.prototype, which adds an extra layer to the prototype chain.

It is reasonable to expectRegExp.prototype.exec to be defined, and for the API for using regular expressions to be unchanged after applying the polyfill in the exceljs documentation.

The fix here restores normal behavior for RegExp.prototype.exec.

Test plan

We verified this in our production application. But since this a bug in the documentation, there are no automated tests included in my PR.

Related to source code (for typings update)

N/A

@SiemienikSiemienik self-requested a reviewNovember 18, 2021 00:58
@Siemienik
Copy link
Member

LGTM, Thank you@joeldenning

jolyndenning reacted with hooray emoji

@SiemienikSiemienik merged commitd786c4d intoexceljs:masterNov 18, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SiemienikSiemienikSiemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jolyndenning@Siemienik

[8]ページ先頭

©2009-2025 Movatter.jp