- Notifications
You must be signed in to change notification settings - Fork1.9k
Protect cell fix#166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Protect cell fix#166
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Author
jayflo commentedAug 10, 2016
You might also consider throwing an error when a cell needs to lookup a style for an index that does not exist. Since Excel is provides correct indices, the only reason the index would not exist during the parsing process would be because of a bug in exceljs. Then the bug could be found much more quickly and be dealt with. |
Closed
This was referencedMar 30, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Integer cell values are interpreted as Dates based on
cellXfs.xfelements inxl/styles.xml. However, when any spreadsheet has "protected" cells, thesexfelements can have the form:Currently, unknown child elements of
xfelements are not handled correctly and this causesxl/styles.xmlto be parsed incorrectly (this is the root of the problem). Whenxl/styles.xmlis parsed incorrectly, thelib/xlsx/style/styles-xform.jsmethodgetStyleModelcan fail to find thenumFmtfor Date types. The change here does not have to be "the fix" (you/we can also add an xform for protected elements) but it does fix the problem since unknown child cells ofxfelements will not cause the parentListXform.parseCloseto remove theparser.Since exceljs may not be able to account for all possible element types in the xml files, it shouldat least ignore unknown elements and only process those that it knows how to "handle." This way exceljs will do its best to work correctly for the subset of features it supports.
Let me know if more info is needed.