Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix #1598 lint violations#1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Siemienik merged 5 commits intoexceljs:masterfromiva2k:master
Feb 14, 2021
Merged

fix #1598 lint violations#1599

Siemienik merged 5 commits intoexceljs:masterfromiva2k:master
Feb 14, 2021

Conversation

iva2k
Copy link
Contributor

Summary

fixes#1598

Test plan

npm run lintnpm runtest

All PASS

@iva2k
Copy link
ContributorAuthor

argh!
git commit hook prettifies the code, removes all parenthesis that were added to fix lint violations "no-mixed-operators Unexpected mix of '+' and '*' ", and fixes end up not going in. I'll update this PR when I find and fix pretty setting that does that.

@iva2k
Copy link
ContributorAuthor

I committed fixes for "no-mixed-operators" violations. It's ready for merge.

@SiemienikSiemienik self-requested a reviewFebruary 12, 2021 02:29
Copy link
Member

@SiemienikSiemienik left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thank you 🥇

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SiemienikSiemienikSiemienik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] npm run lint reports multiple violations
2 participants
@iva2k@Siemienik
[8]ページ先頭
©2009-2025 Movatter.jp